Conversation:
Notices
-
Btw, this regex (in your commit link above) seems faulty:
if(!preg_match('/(\share)$/i', $ero->activity->verb)) {
I think you meant \/share instead of \share :)
-
Now RT's are included in the conversation's feeds. Is this intended? !gnusocial cc @mmn
-
@manuel I think so. I would want repeats included at least. (consider if you want to recreate a conversation on a remote site, you'd want to see who has repeated stuff too)
-
@manuel Which feed are you using for this? I would recommend looking at the "verb" of the post. Give me a link to a feed and I'll see if you have all that's necessary (or I'll add it)
-
You can see that:
<activity:verb>http://activitystrea.ms/schema/1.0/share</activity:verb>
is always "[...]/share" on a repeat. On everything that you're interested to see in the comments feed, it will have:
<activity:verb>http://activitystrea.ms/schema/1.0/post</activity:verb>
instead ([...]/post).
Is it ok to filter on that?
-
@manuel Btw if there is _no_ <activity:verb> element it defaults to a "post" verb :)
-
@manuel Implementado ahorita!!!
-
@manuel It _is_ actually a share verb! But it _contains_ a post verb ;) Only compare the "top" verb in the hierarchy :)
I think you may be comparing at the element. The structure is (greatly simplified) as this: https://social.umeahackerspace.se/attachment/56427
-
^- @manuel After looking at your code, I think you only have to fix the regex! Right now you will never match the share verb. See this post's parent for the solution.
MMN-o ✅⃠
Manuel Ortega
All Hacker Poesy content and data are available under the